HomePhabricator
Diffusion Echo 3 41f541ff67bd

- Fixed an additional warning
Audited41f541ff67bd
Actions

Description

  • Fixed an additional warning

Details

Auditors
Timotheos
Provenance
0xseantaskerAuthored on
0xseantaskerPushed on Mar 29 2019, 10:18 AM
Parents
rEE12b8598a841c: - Fixed a lot of warnings in higher warning level. Mostly order of…
Branches
Unknown
Tags
Unknown

Event Timeline

0xseantasker committed rEE41f541ff67bd: - Fixed an additional warning.Mar 29 2019, 10:18 AM
Restricted Application added an auditor: Timotheos. · View Herald TranscriptMar 29 2019, 10:18 AM
This commit now requires audit.Mar 29 2019, 10:18 AM
Timotheos accepted this commit.Mar 30 2019, 7:25 PM
Timotheos added a subscriber: Timotheos.
Timotheos added inline comments.
/src/Physics/BulletRigidBody.cpp
46

To me, this would be simplified by making semantic inline wrappers for the flag comparisons that internally make the flag comparison but are a single function that descrbies the intent better.

All concerns with this commit have now been addressed.Mar 30 2019, 7:25 PM
0xseantasker marked an inline comment as done.Apr 5 2019, 5:36 PM
0xseantasker added inline comments.
/src/Physics/BulletRigidBody.cpp
46

I agree, good suggestion!

Changes (1)

PathSize
src/
Physics/

rEE41f541ff67bd

View Options

src/Physics/BulletRigidBody.cpp

Loading...
Echo Things · Documentation · Workboard · Source code · There is a developer blog